Skip to content

Mesh Gradients in Compose 1.12 - #936

Merged
riggaroo merged 11 commits into
mainfrom
feature/mesh-gradients
Aug 24, 2026
Merged

Mesh Gradients in Compose 1.12#936
riggaroo merged 11 commits into
mainfrom
feature/mesh-gradients

Conversation

@riggaroo

@riggaroo riggaroo commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

riggaroo added 4 commits May 29, 2026 15:00
* Created `MeshGradientSnippets.kt` featuring examples for basic, complex, and animated mesh gradients using `MeshGradientPainter`.
* Included demonstrations of vertex positioning, color mapping, and custom control points for manipulating mesh curves.
@riggaroo
riggaroo requested review from a team, kkuan2011 and yrezgui as code owners June 4, 2026 09:49
@snippet-bot

snippet-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new Jetpack Compose snippets demonstrating the usage of MeshGradientPainter for basic, control-point-based, complex, and animated mesh gradients. It also updates the Compose BOM version to an alpha release (2026.05.01) and bumps the compileSdk version to 37 in the wearcompanion module. Regarding the feedback, an issue was identified in the MeshGradientAnimation snippet where the gradientPainter is remembered without any keys while capturing the animatedOffset state. This will prevent the painter from updating during the animation, keeping the gradient static. It is recommended to pass animatedOffset as a key to remember.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kkuan2011 kkuan2011 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, except one question:

Comment thread gradle/libs.versions.toml Outdated
@yrezgui
yrezgui removed their request for review June 24, 2026 21:23
@riggaroo
riggaroo requested review from a team as code owners August 24, 2026 11:41
@riggaroo
riggaroo enabled auto-merge (squash) August 24, 2026 12:11
@riggaroo
riggaroo disabled auto-merge August 24, 2026 12:34
@riggaroo
riggaroo enabled auto-merge (squash) August 24, 2026 12:34
@riggaroo
riggaroo requested a review from kkuan2011 August 24, 2026 13:18
}

getByName("release") {
signingConfig = signingConfigs.getByName("debug")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just for some local testing with a release build for performance? Don't think it's a major issue if we keep this, but maybe add a comment noting why this is here.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its to be able to make a release version, its not an issue as its just a sample app that wont be released to google play

@riggaroo
riggaroo merged commit c3042d2 into main Aug 24, 2026
10 checks passed
@riggaroo
riggaroo deleted the feature/mesh-gradients branch August 24, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants